[EventHubs, Azure.Core Shared] Move enqueuedTime from root activity to linked activity (Track Two)#10374
Merged
kinelski merged 3 commits intoAzure:masterfrom Mar 6, 2020
Merged
[EventHubs, Azure.Core Shared] Move enqueuedTime from root activity to linked activity (Track Two)#10374kinelski merged 3 commits intoAzure:masterfrom
kinelski merged 3 commits intoAzure:masterfrom
Conversation
kinelski
added
Event Hubs
Client
kinelski
requested review from
KrzysztofCwalina and
serkantkaraca
as code owners
Contributor
|
Change itself LGTM, the only test being ignored concerns me slightly. |
Contributor
Author
|
A can enable it for the time being, but I believe it will be flaky during nightly runs for the same (unknown) reason similar tests are. I can put the |
pakrym
approved these changes
Mar 6, 2020
jsquire
approved these changes
Mar 6, 2020
Member
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
LGTM.
Which test were we thinking would be a problem?
Contributor
Author
|
The new test: It's basically the same as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10324
Event Hubs:
x-opt-enqueued-timetoenqueuedTime.RunPartitionProcessingAsyncCreatesScopeForEventProcessing, so it's expected to be flaky during nightly runs. It's already being tracked by [EventHubs] Event Processor tests failing during nightly runs (Track Two) #10067. No issues when running locally.Core:
ClientDiagnosticListenertest helper to track linked activities as well, not only their parent ids. I'm keeping theLinksproperty since it's already being used in multiple tests across the repo.